Skip to content

[nfc] Avoid pointer conversions #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2023
Merged

[nfc] Avoid pointer conversions #691

merged 3 commits into from
Sep 1, 2023

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Aug 31, 2023 •
edited
Loading

Preparing for a compiler that's less permissive about pointer conversions.

  1. Use the stdlib's pattern for lazy atomic references, by explicitly declaring the pointer as a computed property.
  2. Use an explicit pointer when a C function isn't detected as such by the compiler.

@glessard
adopt the stdlib’s pattern for atomic lazy references
d45027b 
- avoids reliance on a pointer conversion
@glessard glessard requested review from natecook1000 and Azoy August 31, 2023 21:29
@glessard
Copy link
Contributor Author

@swift-ci please test

@natecook1000
Copy link
Member

LGTM - how did you discover these issues? New compiler, or certain flags?

@glessard
Copy link
Contributor Author

glessard commented Aug 31, 2023 •
edited
Loading

This was using a compiler branch that implements (most of) my restricted pointer conversions pitch.

@glessard
pass a pointer instead of inout conversion
74637cc 
- this function is imported in a way that causes the compiler to not detect it as a C function
@glessard glessard force-pushed the pointer-conversion-restriction branch from 45fdb08 to 74637cc Compare August 31, 2023 22:11
@glessard
Copy link
Contributor Author

@swift-ci please test linux platform

@natecook1000
Copy link
Member

@swift-ci Please test

natecook1000
natecook1000 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@glessard
Copy link
Contributor Author

glessard commented Sep 1, 2023

This should be cherry-picked to the branch used for development snapshot toolchains.

@glessard glessard merged commit 45fd8ec into swiftlang:main Sep 1, 2023
@glessard glessard deleted the pointer-conversion-restriction branch September 1, 2023 15:52
@glessard glessard mentioned this pull request Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman approved these changes

@natecook1000 natecook1000 natecook1000 approved these changes

@Azoy Azoy Awaiting requested review from Azoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glessard @natecook1000 @milseman